-
Notifications
You must be signed in to change notification settings - Fork 117
Fix reboot without message #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
233fb2d
to
19564a4
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a simple fix with a straightforward test included. Maintainers, please approve and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
Adding @github76543 (John) for review. |
What I did
Fix gNOI cold reboot no message issue: sonic-net/sonic-buildimage#22545
How I did it
Use
get
instead of[]
to cover no reboot message caseHow to verify it
Tested gNOI warm reboot on a hardware switch.
Previous command output (if the output of a command-line utility has changed)
no more logs after that
New command output (if the output of a command-line utility has changed)
reboot is executed successfully